From b42bfb80ba210d5546de7dedfbbd64d24c99b66b Mon Sep 17 00:00:00 2001 From: TheGoddessInari Date: Mon, 2 Nov 2020 20:08:23 -0800 Subject: [PATCH] Stop escaping icons in the IconLoader. This is probably overkill anyway. We only need to escape the user-supplied title possibly at worst. Fixes #225 --- app/util/IconLoader.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/util/IconLoader.js b/app/util/IconLoader.js index 47aaddb5..41a8cccf 100644 --- a/app/util/IconLoader.js +++ b/app/util/IconLoader.js @@ -39,8 +39,8 @@ Ext.define('Hamsket.util.IconLoader', { return bg.slice(5, -2); })();`).then(function (backgroundImage) { if (backgroundImage) { - service.setTitle(`${Ext.String.htmlEncode(service.title)}`); - service.fireEvent('iconchange', service, Ext.String.htmlEncode(backgroundImage), service.icon); + service.setTitle(`${Ext.String.htmlEncode(service.title)}`); + service.fireEvent('iconchange', service, backgroundImage, service.icon); } return true; }