Browse Source

Enable opening links in Skype

To make it work, user needs to disable Links Previews in Skype settings.

Fixes #711
pull/2255/head
Ramiro Saenz 6 years ago
parent
commit
ca7693bf84
  1. 2
      app/store/ServicesList.js
  2. 5
      app/ux/WebView.js

2
app/store/ServicesList.js

@ -72,7 +72,7 @@ Ext.define('Rambox.store.ServicesList', {
,description: locale['services[4]']
,url: 'https://web.skype.com/'
,type: 'messaging'
,note: 'Text and Audio calls are supported only. <a href="https://github.com/saenzramiro/rambox/wiki/Skype" target="_blank">Read more...</a>'
,note: 'Text and Audio calls are supported only. Be sure to disable Links Previews to make them work. <a href="https://github.com/ramboxapp/community-edition/wiki/Skype" target="_blank">Read more...</a>'
},
{
id: 'hangouts'

5
app/ux/WebView.js

@ -315,9 +315,8 @@ Ext.define('Rambox.ux.WebView',{
switch ( me.type ) {
case 'skype':
// hack to fix multiple browser tabs on Skype link click, re #11
if ( e.url.match('https:\/\/web.skype.com\/..\/undefined') ) {
e.preventDefault();
return;
if ( require('url').parse(me.down('statusbar #url').html).protocol !== null ) {
e.url = me.down('statusbar #url').html;
} else if ( e.url.indexOf('imgpsh_fullsize') >= 0 ) {
ipc.send('image:download', e.url, e.target.partition);
e.preventDefault();

Loading…
Cancel
Save