From fb4e634cb2723ded3cdf411dbd9ff12ff1537d9e Mon Sep 17 00:00:00 2001 From: TheGoddessInari Date: Sat, 21 Jul 2018 17:54:43 -0700 Subject: [PATCH] Default the "always on status bar" to off for sanity's sake. Remove the option to "toggle" it from the menu, because it never did anything when set to always on, and it'd never be useful to close it from there as opposed to the "x", which also doesn't work with "always on". You'll have to deselect "always on status bar" for your already existing services. Closes #15 --- app.js | 7 ------- app/view/add/Add.js | 2 +- electron/menu.js | 9 --------- 3 files changed, 1 insertion(+), 17 deletions(-) diff --git a/app.js b/app.js index 6e267aa2..02e2f79d 100644 --- a/app.js +++ b/app.js @@ -130,14 +130,7 @@ ipc.on('reloadCurrentService', function(e) { var tab = Ext.cq1('app-main').getActiveTab(); if ( tab.id !== 'ramboxTab' ) tab.reloadService(); }); -// Toggle Status Bar -ipc.on('toggleStatusBar', function() { - var tab = Ext.cq1('app-main').getActiveTab(); - if ( tab.id !== 'ramboxTab' ) { - tab.down('statusbar').closed ? tab.setStatusBar(tab.record.get('statusbar')) : tab.closeStatusBar(); - } -}); // Focus the current service when Alt + Tab or click in webviews textfields window.addEventListener('focus', function() { if(Ext.cq1("app-main")) Ext.cq1("app-main").getActiveTab().down('component').el.dom.focus(); diff --git a/app/view/add/Add.js b/app/view/add/Add.js index bcebd385..8a480a46 100644 --- a/app/view/add/Add.js +++ b/app/view/add/Add.js @@ -182,7 +182,7 @@ Ext.define('Rambox.view.add.Add',{ xtype: 'checkbox' ,boxLabel: 'Always display Status Bar' ,name: 'statusbar' - ,checked: me.edit ? me.record.get('statusbar') : true + ,checked: me.edit ? me.record.get('statusbar') : false ,uncheckedValue: false ,inputValue: true } diff --git a/electron/menu.js b/electron/menu.js index f5de3827..e807ba26 100644 --- a/electron/menu.js +++ b/electron/menu.js @@ -163,15 +163,6 @@ module.exports = function(config) { { type: 'separator' }, - { - label: '&Toggle Status Bar', - click() { - sendAction('toggleStatusBar'); - } - }, - { - type: 'separator' - }, { role: 'zoomin' },